Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(trace-view): Doing the TODO that was waiting on py 3.7+ #29512

Merged
merged 2 commits into from
Oct 25, 2021
Merged

fix(trace-view): Doing the TODO that was waiting on py 3.7+ #29512

merged 2 commits into from
Oct 25, 2021

Conversation

wmak
Copy link
Member

@wmak wmak commented Oct 22, 2021

  • Now that we're on py3.8 we know that dictionaries will be ordered,
    which maens we can use the defaultdict and know that order is
    preserved

@wmak
fix(trace-view): Doing the TODO that was waiting on py 3.7+
a059d86 
- Now that we're on py3.8 we know that dictionaries will be ordered,
  which maens we can use the defaultdict and know that order is
  preserved
@wmak wmak requested a review from a team as a code owner October 22, 2021 14:59
Zylphrex
Zylphrex approved these changes Oct 22, 2021
View reviewed changes
Copy link
Member

@Zylphrex Zylphrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to look this up to be sure but defaultdict is a subclass of dict meaning it also gets the same insertion order guarantee.

@wmak
Copy link
Member Author

wmak commented Oct 22, 2021

Had to look this up to be sure but defaultdict is a subclass of dict meaning it also gets the same insertion order guarantee.

Ah yeah my bad should've included this in the comment

@wmak wmak enabled auto-merge (squash) October 25, 2021 15:46
@wmak wmak merged commit 373261d into master Oct 25, 2021
@wmak wmak deleted the wmak/fix/ordered-dict-hack branch October 25, 2021 15:57
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Zylphrex Zylphrex Zylphrex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wmak @Zylphrex