test: remove mock compat #29501
Merged
test: remove mock compat #29501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuarli
commented
Oct 21, 2021
| @@ -1,5 +1,6 @@ | |||
| import uuid | |||
| from datetime import timedelta | |||
| from unittest import mock, zip | |||
wedamija
approved these changes
Oct 22, 2021
wedamija
reviewed
Oct 22, 2021
Comment on lines
+186
to
+204
|
|
||
| # @mock.patch("sentry.buffer.redis.RedisBuffer._make_key", mock.Mock(return_value="foo")) | ||
| # def test_incr_uses_signal_only(self): | ||
| # now = datetime(2017, 5, 3, 6, 6, 6, tzinfo=timezone.utc) | ||
| # client = self.buf.cluster.get_routing_client() | ||
| # model = mock.Mock() | ||
| # model.__name__ = "Mock" | ||
| # columns = {"times_seen": 1} | ||
| # filters = {"pk": 1, "datetime": now} | ||
| # self.buf.incr(model, columns, filters, extra={"foo": "bar", "datetime": now}, signal_only=True) | ||
| # result = client.hgetall("foo") | ||
| # assert result == { | ||
| # "e+foo": '["s","bar"]', | ||
| # "e+datetime": '["d","1493791566.000000"]', | ||
| # "f": '{"pk":["i","1"],"datetime":["d","1493791566.000000"]}', | ||
| # "i+times_seen": "1", | ||
| # "m": "mock.mock.Mock", | ||
| # "s": "1" | ||
| # } |
There was a problem hiding this comment.
Why are we commenting this out?
There was a problem hiding this comment.
''' imo is not the best way to comment things out, just a small thing i noticed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in Python 3.6, we couldn't remove the mock backport due to Python issue37972. Now, we can swap it out for the stdlib.