feat(discover): Added world map mini graph to Discover saved query list #29493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
|
Drafting this for now, still deciding on what it should visually look like |
71750ca to
0504234
Compare
Increase query card render height to 150 px to match the Dashboard cards and to get a better aspect ratio on world maps.
…er-world-map-mini-chart
|
Reopened, we decided to move forward with the world map preview |
… into feat/discover-world-map-mini-chart
wmak
approved these changes
Oct 27, 2021
Comment on lines
83
to
84
| zoom: fromDiscover ? 1.1 : fromDiscoverQueryList ? 0.9 : 1.3, | ||
| center: [10.97, fromDiscoverQueryList ? -12 : 9.71], |
There was a problem hiding this comment.
Should we move some of these magic numbers to constants?
There was a problem hiding this comment.
👍 updated!
…er-world-map-mini-chart
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off
feat/discover-bar-chart