Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(perf): Add vital widget for performance landing #29489

Merged
merged 7 commits into from
Oct 22, 2021
Merged

feat(perf): Add vital widget for performance landing #29489

merged 7 commits into from
Oct 22, 2021

Conversation

k-fish
Copy link
Member

@k-fish k-fish commented Oct 21, 2021

Summary

This adds a vital widget that will pull the top list of worst vitals
(for LCP at the moment) and list out the other vitals in terms of their
good / meh / poor numbers, by count.

Other:

  • Removed the MultiSeriesResult type since.. we don't need more types.
  • Modified the vitalBar so it can show just the bar or just the details.

@k-fish
feat(perf): Add vital widget for performance landing
5c70293 
This adds a vital widget that will pull the top list of worst vitals
(for LCP at the moment) and list out the other vitals in terms of their
good / meh / poor numbers, by count.
@k-fish k-fish requested a review from a team October 21, 2021 18:25
@k-fish k-fish requested a review from a team as a code owner October 21, 2021 18:25
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2021 •
edited
Loading

size-limit report

Path Base Size (d014d55) Current Size Change
src/sentry/static/sentry/dist/entrypoints/app.js 52.75 KB 52.74 KB -0.01% 🔽
src/sentry/static/sentry/dist/entrypoints/sentry.css 70.89 KB 70.89 KB 0%

@k-fish k-fish enabled auto-merge (squash) October 22, 2021 17:27
@k-fish k-fish merged commit 5db96d0 into master Oct 22, 2021
@k-fish k-fish deleted the feat/perf-landing-add-vitals-widget branch October 22, 2021 19:24
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Zylphrex Zylphrex Zylphrex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-fish @Zylphrex