-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(discover): Pick the correct y-axis for unfurls #29488
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmak
approved these changes
Oct 21, 2021
Comment on lines
51
to
57
def is_aggregate(field: str) -> bool: | ||
field_match = re.match(AGGREGATE_PATTERN, field) | ||
equation_match = re.match(AGGREGATE_BASE, field) and is_equation(field) | ||
if field_match or equation_match: | ||
return True | ||
|
||
return False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
could either do
faster but messy
Suggested change
def is_aggregate(field: str) -> bool: | |
field_match = re.match(AGGREGATE_PATTERN, field) | |
equation_match = re.match(AGGREGATE_BASE, field) and is_equation(field) | |
if field_match or equation_match: | |
return True | |
return False | |
def is_aggregate(field: str) -> bool: | |
field_match = re.match(AGGREGATE_PATTERN, field) | |
if field_match: | |
return True | |
equation_match = re.match(AGGREGATE_BASE, field) and is_equation(field) | |
if equation_match: | |
return True | |
return False |
cleaner:
Suggested change
def is_aggregate(field: str) -> bool: | |
field_match = re.match(AGGREGATE_PATTERN, field) | |
equation_match = re.match(AGGREGATE_BASE, field) and is_equation(field) | |
if field_match or equation_match: | |
return True | |
return False | |
def is_aggregate(field: str) -> bool: | |
field_match = re.match(AGGREGATE_PATTERN, field) | |
equation_match = re.match(AGGREGATE_BASE, field) and is_equation(field) | |
return (field_match or equation_match) is not None |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some Discover Saved queries that don't have
yAxis saved on the Database. To avoid yAxis mix ups
when these links are shared, we just want to mimic
how Discover displays yAxis - picking the first option
when yAxis isn't explicitly specified.