Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Always allow deletion of custom symbol sources [NATIVE-270] #29482

Merged
merged 5 commits into from
Oct 27, 2021
Merged

fix: Always allow deletion of custom symbol sources [NATIVE-270] #29482

merged 5 commits into from
Oct 27, 2021

Conversation

loewenheim
Copy link
Contributor

This changes validate_symbolSources so that the organizations:custom-symbol-sources flag is only checked if the user is trying to add new sources. Deletion is always allowed.

@loewenheim loewenheim requested a review from flub October 21, 2021 13:23
flub
flub reviewed Oct 21, 2021
View reviewed changes
Copy link
Contributor

@flub flub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a unittest to tests/sentry/api/endpoints/test_project_details.py ProjectUpdateTest that checks this?

@loewenheim loewenheim requested a review from flub October 27, 2021 11:08
flub
flub reviewed Oct 27, 2021
View reviewed changes
Copy link
Contributor

@flub flub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT but... github won't let me hit approve

@loewenheim loewenheim requested review from flub and a team October 27, 2021 11:37
@loewenheim loewenheim merged commit bf047c5 into master Oct 27, 2021
@loewenheim loewenheim deleted the fix/remove-asc-source branch October 27, 2021 11:42
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Swatinem Swatinem Swatinem approved these changes

@flub flub Awaiting requested review from flub

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loewenheim @flub @Swatinem