feat(perf): Add histogram widget for perf landing #29479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the histogram widget to performance landing. It splits up the existing histogram chart for the landing page into the query portion and chart portion, and exports the chart with some extra options for the widget. Other: - Added the minichart row for the frontend pageload view.
size-limit report
|
Zylphrex
approved these changes
Oct 21, 2021
| }; | ||
| }, [props.eventView, props.fields, props.organization.slug]); | ||
|
|
||
| const onFilterChange = () => {}; |
There was a problem hiding this comment.
Is this intentionally not implemented?
| 'LCP Distribution' | ||
| ); | ||
|
|
||
| // Add histogram mock |
There was a problem hiding this comment.
Is this a TODO for later? Can we make that explicit? This just looks like a regular comment at a glance.
There was a problem hiding this comment.
Yep, forgot the todo, thx.
| 'FCP Distribution' | ||
| ); | ||
|
|
||
| // Add histogram mock |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds the histogram widget to performance landing. It splits up the existing histogram chart for the landing page into the query portion and chart portion, and exports the chart with some extra options for the widget.
Other: