feat(cmp_alerts): Show thresholds for change alerts in the alert details sidebar #29472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
matejminar
approved these changes
Oct 21, 2021
|
|
||
| type Props = React.ComponentProps<typeof SvgIcon>; | ||
|
|
||
| const IconRectangle = React.forwardRef(function IconRectangle( |
There was a problem hiding this comment.
Should we add this to our storybook collection of icons?
There was a problem hiding this comment.
For sure, I can add it in a separate pr
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the alert details page sidebar for the change alerts. If it's a change alert we show comparison scheme in writing and a more descriptive threshold description for other alerts. Also added actions for critical and warning thresholds based on the new design. Also removed the threshold lines for change alerts.
Old (same for change/non-change alerts):
New (non-change alert):
New (change alert):
Jira: WOR-1450