Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmp_alerts): Change the default timeWindow and changeDelta options for change alerts #29468

Merged

Conversation

taylangocmen
Copy link
Contributor

This changes the default select value for timeWindow and changeDelta if the change alert option is selected in the alert builder. New defaults are 1h/1w respectively. Also changed these selects to SelectControl to be able to initialize from props.

Jira: WOR-1436

@taylangocmen taylangocmen requested a review from a team October 21, 2021 00:21
@taylangocmen taylangocmen merged commit 43c032e into master Oct 21, 2021
@taylangocmen taylangocmen deleted the taylangocmen/change-alert-comparisoninterval-choices branch October 21, 2021 03:44
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants