feat(insights): Record all instances of SET_RESOLVED_IN_PULL_REQUEST activity in GroupHistory
#29466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanpurkhiser
approved these changes
Oct 21, 2021
8d050c3 to
fa8a25f
Compare
…` activity in `GroupHistory` We missed a spot here, just simplifying the code to make it easier to catch all cases. This code is completely untested from what I can tell, not going to add tests here now
fa8a25f to
0c4b1d9
Compare
ahmedetefy
approved these changes
Oct 21, 2021
ahmedetefy
reviewed
Oct 21, 2021
| title="very cool PR to fix the thing", | ||
| message=f"Foo Biz\n\nFixes {group2.qualified_short_id}", | ||
| ) | ||
| with self.feature("organizations:group-history"): |
There was a problem hiding this comment.
Wasn't this flag removed in the other PR?
There was a problem hiding this comment.
Yeah, I made all these prs in a separate order, I'll merge the other one first and update this I'll merge this first and update the feature removing one
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We missed a spot here, just simplifying the code to make it easier to catch all cases.