feat(perf): Add trends widgets for landing page v3 #29461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds trends widgets in the new generic performance widget format. Clicking on the transaction will bring you to the trends page scope to that transaction, which should help discovery of trends as a feature. Made some modifications to the trends chart and query to support alternate use, and moved a few shared functions. Other: - Did some light fixes for multi-breakpoints, will need to do more still since it's not great between wide screen and phone size.
size-limit report
|
9ddf073 to
cc4ecb3
Compare
Zylphrex
reviewed
Oct 21, 2021
| @@ -59,9 +64,9 @@ export function getTrendsRequestPayload(props: RequestProps) { | |||
| function TrendsDiscoverQuery(props: Props) { | |||
| return ( | |||
| <GenericDiscoverQuery<TrendsData, TrendsRequest> | |||
| {...props} | |||
There was a problem hiding this comment.
Was there a reason for this change? Seems unlikely that this changed the behaviour of anything but just want to be sure.
There was a problem hiding this comment.
In general, I'd say spreads should always be first so hardcoded settings are applied with precedence, unless there is a specific thing that props will override. In this specific instance it's been a couple week since I actually wrote that line but I believe there was a bug with props containing extra keys and it causing an issue.
| field: 'trend_percentage()', | ||
| }, | ||
| ]; | ||
| const rest = {eventView, ...omit(props, 'eventView')}; |
There was a problem hiding this comment.
Nit: This can be done without the use of omit right?
Suggested change
| const rest = {eventView, ...omit(props, 'eventView')}; | |
| const rest = {...props, eventView}; |
Zylphrex
approved these changes
Oct 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds trends widgets in the new generic performance widget format. Clicking on the transaction will bring you to the trends page scope to that transaction, which should help discovery of trends as a feature. Made some modifications to the trends chart and query to support alternate use, and moved a few shared functions.
Other: