ref(js): Introduce simple useProjects #29457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
|
This is super basic right now, a bunch of tests are failing that I'm fixing, then right after this we'll have all the project util stuff end up in here 😎 |
01d5558 to
aadfc53
Compare
aadfc53 to
117e6df
Compare
117e6df to
6e3ab87
Compare
|
@priscilawebdev @matejminar could I get a review for all the tests I changed. Because withProjects uses the hook now it needed a lot more |
davidenwang
approved these changes
Oct 26, 2021
| expect(initialData.router.replace).toHaveBeenLastCalledWith({ | ||
| pathname: undefined, | ||
| query: {environment: [], project: [0]}, | ||
| query: {cursor: undefined, environment: [], project: [2]}, |
There was a problem hiding this comment.
is it bad that we changed the functionality here?
There was a problem hiding this comment.
So the reason this changed is a detail of the test implementation because we had mocked the return value incorrectly in the test before.
So it's actually the same 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the withProjects over to the useProjects hook, which very basically just connects to the store ATM