fix(chartcuterie): Render other as gray when included in top-5 #29455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This fixes chart rendering when Other is a series which was appearing as just another series, instead of the specific gray we use in the UI - The backend handles series names overlapping with `Other` already, so we can easily just check that the series name is Other and update colours accordingly
| [1615879620, [{"count": 2}]], | ||
| ], | ||
| "order": 2, | ||
| }, |
There was a problem hiding this comment.
🙏 Thank you for adding a test for it
| @@ -169,7 +169,11 @@ discoverCharts.push({ | |||
| } | |||
|
|
|||
| const stats = Object.values(data.stats); | |||
| const color = theme.charts.getColorPalette(stats.length - 2); | |||
| const hasOther = Object.keys(data.stats).includes('Other'); | |||
| const color = theme.charts.getColorPalette(stats.length - 2 - (hasOther ? 1 : 0)); | |||
There was a problem hiding this comment.
The way this getColorPalette thing works with the math is so confusing 😨
evanpurkhiser
approved these changes
Oct 20, 2021
|
Yeah, the diff looks good to me |
|
lgtm. Looks like acceptance tests are flaking |
shruthilayaj
approved these changes
Oct 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as just another series, instead of the specific gray we use in the UI
Otheralready, sowe can easily just check that the series name is Other and update
colours accordingly