feat(discover): Disable other y axis options when in a display mode that doesnt support multi y axis #29450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmak
approved these changes
Oct 21, 2021
| @@ -140,7 +140,8 @@ class OptionCheckboxSelector extends Component<Props, State> { | |||
| title={ | |||
| disabled | |||
There was a problem hiding this comment.
Thoughts on removing the checkbox entirely instead of disabling it instead?
There was a problem hiding this comment.
I like this idea! I've made the update to just hide the checkbox instead on views that don't support multi y axis
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When in a Display Mode that doesn't support multi y axis selection (like World Map and Top Period), hide the checkbox for Y-Axis options:
Display modes that support multi y will still have checkboxes:
