Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): Add absolute numbers to release adoption charts #29436

Merged
merged 1 commit into from
Oct 20, 2021
Merged

feat(ui): Add absolute numbers to release adoption charts #29436

merged 1 commit into from
Oct 20, 2021

Conversation

matejminar
Copy link
Member

@matejminar matejminar commented Oct 20, 2021 •
edited
Loading

This PR adds absolute numbers to the existing percentages on release adoption charts.

image

@matejminar matejminar requested a review from a team as a code owner October 20, 2021 12:54
@matejminar matejminar requested a review from a team October 20, 2021 12:54
@github-actions
Copy link
Contributor

size-limit report

Path Base Size (c8a19f9) Current Size Change
src/sentry/static/sentry/dist/entrypoints/app.js 52.74 KB 52.73 KB -0.01% 🔽
src/sentry/static/sentry/dist/entrypoints/sentry.css 70.89 KB 70.89 KB 0%

priscilawebdev
priscilawebdev approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@priscilawebdev priscilawebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@matejminar matejminar merged commit 01bbc1b into master Oct 20, 2021
@matejminar matejminar deleted the feat/release-absolute-adoption branch October 20, 2021 13:22
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@priscilawebdev priscilawebdev priscilawebdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matejminar @priscilawebdev