ref(sentry-test/enzyme): Add migration warning message #29427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priscilawebdev
commented
Oct 20, 2021
|
|
||
| import {lightTheme} from 'app/utils/theme'; | ||
|
|
||
| /** | ||
| * @deprecated |
There was a problem hiding this comment.
was not sure if I should already add @deprecated here, since there will be an eslint rule too
There was a problem hiding this comment.
I think having both is fine. The doc string annotation doesn't cost anything and could help folks who have TSC setup but not eslint in their editor.
markstory
approved these changes
Oct 20, 2021
|
|
||
| import {lightTheme} from 'app/utils/theme'; | ||
|
|
||
| /** | ||
| * @deprecated |
There was a problem hiding this comment.
I think having both is fine. The doc string annotation doesn't cost anything and could help folks who have TSC setup but not eslint in their editor.
973e116 to
ad10cd0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are migrating our enzyme tests to the React Testing Library, we would like to warn devs that the use of enzyme
shallowandmountWithThemeis not recommended