Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types(python): Group API Helpers #29424

Merged
merged 7 commits into from
Oct 20, 2021
Merged

types(python): Group API Helpers #29424

merged 7 commits into from
Oct 20, 2021

Conversation

mgaeta
Copy link
Contributor

@mgaeta mgaeta commented Oct 20, 2021 •
edited
Loading

Adding types to the group API helper files. This builds on #29302 which splits up a large file.

@mgaeta mgaeta requested a review from a team October 20, 2021 01:05
@mgaeta mgaeta requested a review from a team as a code owner October 20, 2021 01:05
evanh
evanh reviewed Oct 20, 2021
View reviewed changes
Copy link
Member

@evanh evanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! One small fix, also the backend typing CI is failing.

@mgaeta mgaeta requested a review from evanh October 20, 2021 16:43
evanh
evanh approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@evanh evanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but please fix the CI check before merging.

@mgaeta mgaeta force-pushed the ref/update-groups-3 branch from 2a89e23 to f873b8a Compare October 20, 2021 17:23
Base automatically changed from ref/update-groups to master October 20, 2021 18:05
@mgaeta mgaeta requested a review from a team as a code owner October 20, 2021 18:05
@mgaeta mgaeta requested a review from a team October 20, 2021 18:05
@mgaeta mgaeta force-pushed the ref/update-groups-3 branch from f873b8a to de0b573 Compare October 20, 2021 18:07
@mgaeta mgaeta merged commit f71ced8 into master Oct 20, 2021
@mgaeta mgaeta deleted the ref/update-groups-3 branch October 20, 2021 18:54
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@evanh evanh evanh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgaeta @evanh