build(ci): Remove if: always() conditions from workflows
#29414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyvg
commented
Oct 19, 2021
| @@ -102,7 +103,7 @@ jobs: | |||
| github-token: ${{ steps.token.outputs.token }} | |||
|
|
|||
| - name: tsc | |||
| if: always() && steps.changes.outputs.frontend == 'true' | |||
| if: steps.dependencies.outcome == 'success' && steps.changes.outputs.frontend == 'true' | |||
There was a problem hiding this comment.
We want this to run regardless of results of eslint, but it does depend on yarn install being successful.
https://docs.github.com/en/actions/learn-github-actions/contexts#steps-context
joshuarli
approved these changes
Oct 19, 2021
I do not remember why this was added, but removing these because it is adding noise to our workflow annotations when a previous step fails. If our setup steps fails, these steps will always fail as well, so there is not point in attempting to run them.
fb04f08 to
6c23277
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not remember why this was added, but removing these because it is adding noise to our workflow annotations when a previous step fails. If our setup steps fails, these steps will always fail as well, so there is not point in attempting to run them.