Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): made alert wizard chart consistent with Discover #29397

Merged
merged 1 commit into from
Oct 18, 2021
Merged

fix(ui): made alert wizard chart consistent with Discover #29397

merged 1 commit into from
Oct 18, 2021

Conversation

robinrendle
Copy link
Contributor

Making the Alert Wizard chart more consistent with the way we present charts in Discover — with an area chart. Also just looks way better.

Before

CleanShot 2021-10-18 at 16 17 57

After

CleanShot 2021-10-18 at 16 15 57

@robinrendle robinrendle requested a review from a team October 18, 2021 23:20
@robinrendle robinrendle merged commit 93370a6 into master Oct 18, 2021
@robinrendle robinrendle deleted the rr/alert-area-chart branch October 18, 2021 23:45
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@evanpurkhiser evanpurkhiser evanpurkhiser approved these changes

@leedongwei leedongwei leedongwei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robinrendle @evanpurkhiser @leedongwei