feat(discover) Add equation support to SnQL #29394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This allows the snql query builder to accept equations - Had to introduce some wonky importing here to avoid circular imports - Otherwise the idea was to pass the parsed equations to the query builder which can then resolve the functions and columns as needed
Zylphrex
approved these changes
Oct 19, 2021
Comment on lines
+347
to
+349
| # TODO: currently returning "resolved_equations" for the json syntax | ||
| # once we're converted to SnQL this should only return parsed_equations | ||
| parsed_equations.append(parsed_equation) |
There was a problem hiding this comment.
Nit: Move this below the resolved_equations.append(...) because it is now splitting apart the corresponding comment.
| result = Function(equation.operator, [lhs, rhs], alias) | ||
| return result | ||
|
|
||
| def _resolve_equation_side(self, side: OperationSideType) -> Union[SelectType, float]: |
There was a problem hiding this comment.
Nit: I think this is called an operand.
There was a problem hiding this comment.
😓 I'll update in a follow up PR, cause I've used side in a buuunch of places
src/sentry/search/events/fields.py
Outdated
Comment on lines
2893
to
2894
| def is_equation_column(self, column: SelectType) -> bool: | ||
| return isinstance(column, CurriedFunction) and column.alias.startswith("equation[") |
There was a problem hiding this comment.
If I recall correctly, equations have to contain at least 1 operator, meaning a literal is not a valid equation right?
There was a problem hiding this comment.
Yep! A valid equation has to contain at least 1 operator 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
builder which can then resolve the functions and columns as needed