Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scim): check slugified input instead of using name #29383

Merged
merged 3 commits into from
Oct 19, 2021
Merged

fix(scim): check slugified input instead of using name #29383

merged 3 commits into from
Oct 19, 2021

Conversation

JoshFerge
Copy link
Member

  • For SCIM, we need to store the unmodified team name for responses to IDPs, so originally we matched on it.
  • This can cause problems since name is deprecated elsewhere and isn't updated
  • Instead, we'll slugify the input and check against the slug.
  • For okta this wasn't causing problems since they have a UI where you select which team you want to sync it to, but for Azure it could cause an issue where you sync to the wrong team in sentry.
  • I've checked prod and ensured there are no conflicts in teams that are currently synced with SCIM.

@JoshFerge JoshFerge requested a review from a team as a code owner October 18, 2021 19:06
@JoshFerge JoshFerge merged commit 71bfe74 into master Oct 19, 2021
@JoshFerge JoshFerge deleted the jferg/scim-team-sync-slug branch October 19, 2021 17:10
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maxiuyuan maxiuyuan maxiuyuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshFerge @maxiuyuan