fix(integrations): Populate fields with default value to avoid empty labels submitting #29368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgaeta
suggested changes
Oct 18, 2021
static/app/components/externalIssues/abstractExternalIssueForm.tsx
Outdated
Show resolved
Hide resolved
static/app/components/externalIssues/abstractExternalIssueForm.tsx
Outdated
Show resolved
Hide resolved
mgaeta
reviewed
Oct 18, 2021
static/app/components/externalIssues/abstractExternalIssueForm.tsx
Outdated
Show resolved
Hide resolved
size-limit report
|
mgaeta
approved these changes
Oct 18, 2021
d188c1d to
6142f3e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will prevent the submitting external issue forms with empty labels for async field. The problem would arise since typing into any of these inputs sends a third party request which will return the results based on what the user typed. Since we have a default reporter for the user, it would often start with the a choice (
[value, label]) on load. When the user types into the field, if the result doesn't include the default value, when we overwrite the choices we lose thelabelassociated with it, and the field appears empty. This PR will retain the current value even when the user types into the field.With the default option pre-loaded
After selecting a new option