perf(issue_alerts): Process issue alert filters before conditions #29367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've seen that some large customers set up many very similar alert rules. These rules tend to contain a match on a specific tag to filter the alert to go to a specific team. It makes sense to run these cheap filters first so that we exit early, before performing more expensive snuba queries. Even though the queries are cached, we still spend a long time fetching values from the cache, so this can cause pipeline processing issues. Refs #WOR-1296
ahmedetefy
approved these changes
Oct 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen that some large customers set up many very similar alert rules. These rules tend to
contain a match on a specific tag to filter the alert to go to a specific team.
It makes sense to run these cheap filters first so that we exit early, before performing more
expensive snuba queries. Even though the queries are cached, we still spend a long time fetching
values from the cache, so this can cause pipeline processing issues.
Also refactored a bit to remove some duplication, since conditions and filters are handled in the
same way
Refs #WOR-1296