feat(workflow): Adding some group history entries across app #29355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add more places where we write these rows
121d5e7 to
124a42d
Compare
wedamija
approved these changes
Oct 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support the recently added endpoints for team insights (time to resolution and issues reviewed), the GroupHistory model needs to be appropriately populated. This PR aims to do that.
While adding these status', I also realized we may need to distinguish between resolution as an action, and resolution as a status. For example:
The issues reviewed API counts marking as resolved (immediately), and marking as resolved in [release/commit] as actions, so I create GroupHistory entries to properly track those when they happen. However, when the release/commit causes the group to be resolved, I am also creating another RESOLVED entry and this would currently get counted as 2 actions on the same group.
I haven't thought of a way to solve this without losing granularity for something else without having two status' such as
SET_RESOLVEDandRESOLVED. In this case, the reviewed issues API would only countSET_RESOLVED(and other actions), where as the time to resolution API would only countRESOLVEDentries. The caveat here is that someone clicking "Resolve" in the UI would have to make two entries..