Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lpq): Update project lpq status to not be hardcoded [NATIVE-244] #29351

Merged
merged 2 commits into from
Oct 19, 2021
Merged

feat(lpq): Update project lpq status to not be hardcoded [NATIVE-244] #29351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8b39c3
feat(lpq): Update project lpq status to not be hardcoded
Oct 15, 2021
a02374b
Update number of expected queries
Oct 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/sentry/api/serializers/models/project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
)
from sentry.notifications.types import NotificationSettingOptionValues, NotificationSettingTypes
from sentry.snuba import discover
from sentry.tasks.store import should_demote_symbolication
from sentry.utils import json
from sentry.utils.compat import zip

Expand Down Expand Up @@ -563,7 +564,7 @@ def serialize(self, obj, attrs, user):
"dateCreated": obj.date_added,
"environments": attrs["environments"],
"eventProcessing": {
"symbolicationDegraded": False,
"symbolicationDegraded": should_demote_symbolication(obj.id),
},
"features": attrs["features"],
"firstEvent": obj.first_event,
Expand Down
3 changes: 3 additions & 0 deletions tests/sentry/api/endpoints/test_organization_details.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,9 @@ def test_with_projects(self):
# TODO(mgaeta): Extra query while we're "dual reading" from UserOptions and NotificationSettings.
expected_queries += 1

# Symbolication Low Priority Queue stats reads two killswitches
expected_queries += 8

with self.assertNumQueries(expected_queries, using="default"):
response = self.get_success_response(self.organization.slug)

Expand Down