ref(tests): Use screen for querying in RTL #29312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice... thanks @matejminar 🙏
would you have a link to share? I'd love to read more about it |
priscilawebdev
approved these changes
Oct 14, 2021
|
@priscilawebdev he talks about it in the course and it's also mentioned in this article: https://kentcdodds.com/blog/common-mistakes-with-react-testing-library#not-using-screen |
markstory
approved these changes
Oct 14, 2021
This was referenced Oct 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The benefit of using
screenis you no longer need to keep the render call destructure up-to-date as you add/remove the queries you need. You only need to typescreen.and let your editor's magic autocomplete take care of the rest.screenwas added in react testing library v9.This is now the preferred/suggested way of querying by the library author.