ref(grouprelease): Buffer updates to GroupRelease.last_seen #29311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to high concurrency of `save_event` workers the 1m check is not working as expected especially during spikes and we consistently do high number of mutations on GroupRelease.last_seen. Buffering the updates will hopefully reduce the number of updates and prevent spikes in locks as well.
f3e4260 to
a4add22
Compare
wedamija
approved these changes
Oct 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to high concurrency of
save_eventworkers the 1m check is not working asexpected especially during spikes and we consistently do high number of
mutations on GroupRelease.last_seen. Buffering the updates will hopefully
reduce the number of updates and prevent spikes in locks as well.