feat(workflow): Adding 'this week' totals, dynamic average, and merging into one query #29301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wedamija
reviewed
Oct 13, 2021
| current_day, agg_project_counts = start, {} | ||
| agg_project_counts = {} | ||
| project_avgs = defaultdict(int) | ||
| this_week_start = now() - timedelta(days=7) |
There was a problem hiding this comment.
Should this be rounded down to the start of the day?
There was a problem hiding this comment.
Hmm, then we'd also need to change the end so that it remains 7 days right? Or perhaps we could not include today and just do the previous 7 days?
scttcper
approved these changes
Oct 13, 2021
wedamija
approved these changes
Oct 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the fixed 12 week average to be the average over the selected time period instead. It also now returns the count of releases in the last week for each project, and in making these changes, I was able to merge these two queries into one.