feat(dev): Upgrade zookeeper/kafka dev containers for Intel hosts #29293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #28574, we upgraded the versions of zookeeper/kafka to 6.x only for Apple arm64 hosts. When trying to use such version on Intel, it would fail because version 6.x requires specifying the path to `data` *absolutely* (see [docs][docs]), otherwise, you would get this error: > Command [/usr/local/bin/dub path /var/lib/kafka/data writable] FAILED ! If you don't rename the key of the moount bind, users with an existing set-up would not get the absolue path properly configured, thus, they would still face the issue (see [comment][comment]). In other words, people starting from scratch would have no issues. At the time, we decided to back things out and investigate later. This change reunites Intel and arm64 hosts. [docs]: https://docs.confluent.io/platform/current/installation/docker/operations/external-volumes.html#data-volumes-for-kafka-and-zk [comment]: #28574 (comment)
armenzg
commented
Oct 13, 2021
| "environment": {"ZOOKEEPER_CLIENT_PORT": "2181"}, | ||
| "volumes": {"zookeeper": {"bind": "/var/lib/zookeeper"}}, | ||
| "volumes": {"zookeeper_6": {"bind": "/var/lib/zookeeper/data"}}, |
There was a problem hiding this comment.
Changing the key is what allows users that come from version 5.x to not require a fresh set up.
|
@avgupta456 would you mind testing it locally? |
BYK
approved these changes
Oct 14, 2021
I'm aware of that. I've added it to the backlog. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #28574, we upgraded the versions of zookeeper/kafka to 6.x only for Apple
arm64 hosts.
When trying to use such version on Intel, it would fail because version 6.x
requires specifying the path to
dataabsolutely (see docs), otherwise, you would get thiserror:
If you don't rename the key of the moount bind, users with an existing set-up would not get
the absolue path properly configured, thus, they would still face the issue (see comment).
In other words, people starting from scratch would have no issues.
At the time, we decided to back things out and investigate later.
This change reunites Intel and arm64 hosts.