fix: Use counters instead of gauges #29291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
approved these changes
Oct 14, 2021
flub
reviewed
Oct 14, 2021
| @@ -282,7 +282,7 @@ def _do_symbolicate_event( | |||
| # check whether the event is in the wrong queue and if so, move it to the other one. | |||
| # we do this at most SYMBOLICATOR_MAX_QUEUE_SWITCHES times. | |||
| if queue_switches >= SYMBOLICATOR_MAX_QUEUE_SWITCHES: | |||
| metrics.gauge("tasks.store.symbolicate_event.low_priority.max_queue_switches", 1) | |||
| metrics.incr("tasks.store.symbolicate_event.low_priority.max_queue_switches", sample_rate=1) | |||
There was a problem hiding this comment.
these weren't emitted yet so nothing happened. but just changing the data type of a metrics is usually not something one can just do. no idea how datadog deals with this. just to keep in mind next time 😄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also a bonus fix for a bug that the linter just noticed.