ref(js): Rewrite Sidebar as a functional component #29278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanpurkhiser
commented
Oct 13, 2021
|
|
||
| // TODO(billy): We should consider moving this into a component |
There was a problem hiding this comment.
or even better into a hook 😏
e1a0c3b to
5ea8ea8
Compare
size-limit report
|
matejminar
approved these changes
Oct 13, 2021
5ea8ea8 to
5969a4e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out this didn't have a lot of state, but had a lot of gross componentDidMount / componentDidUpdate kludges that could be represented as
useEffectsmuch nicer.