feat(u2f): disabled enrolling the same device for u2f #29276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
JoshFerge
reviewed
Oct 18, 2021
| promise = u2f.sign(this.props.challengeData.authenticateRequests); | ||
| } else if (this.props.flowMode === 'enroll') { | ||
| const {registerRequests, registeredKeys} = this.props.challengeData; | ||
| promise = u2f.register(registerRequests as any, registeredKeys as any); |
There was a problem hiding this comment.
i believe so, i think it failed the linting checks without it since register doesn't take registeredKeys in the api function
This was referenced Oct 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user will no longer be able to enrol the same u2f device twice.
u2f.register() with registeredKeys passed in will error if the device is been registered already. If so, we want to display that it has been registered and not allow the user to continue with adding a u2f key.
Solves: https://getsentry.atlassian.net/browse/ER-640
https://getsentry.atlassian.net/browse/ER-642