fix(migration) Fix exception in data migration 0233 #29271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was tested using the wrong method, and wasn't tested against the correct version of the `apps` that Django uses in production. That testing uncovered some bugs in the fields being used that are present on the regular models but not in the models used in migrations.
wedamija
approved these changes
Oct 12, 2021
|
This PR has a migration; here is the generated SQL --
-- MIGRATION NOW PERFORMS OPERATION THAT CANNOT BE WRITTEN AS SQL:
-- Raw Python operation
-- |
wedamija
approved these changes
Oct 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was tested using the wrong method, and wasn't tested against the correct
version of the
appsthat Django uses in production. That testing uncoveredsome bugs in the fields being used that are present on the regular models but
not in the models used in migrations.
This both fixes the old migration (to avoid a bunch of error messages getting logged)
as well as adding a new migration to ensure customers who already ran the old
migration are automatically brought up to date.
This migration wasn't actually run in prod, since I had manually done the migration
with a separate script earlier. I tested this using the correct version of the apps
locally. This needs to get merged before the next release gets cut.