feat(u2f): Enable renaming u2f device #29263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
static/app/views/settings/account/accountSecurity/accountSecurityDetails.tsx
Outdated
Show resolved
Hide resolved
static/app/views/settings/account/accountSecurity/accountSecurityDetails.tsx
Outdated
Show resolved
Hide resolved
| if (id !== 'u2f' || !isEnrolled) { | ||
| return null; | ||
| } | ||
| class U2fEnrolledDetails extends React.Component<Props, State> { |
There was a problem hiding this comment.
Instead of making this a React.Component can we useState for any state it needs?
size-limit report
|
JoshFerge
reviewed
Oct 18, 2021
| device["name"] = request.data.get("name") | ||
| authenticator.save() | ||
|
|
||
| return Response(status=status.HTTP_201_CREATED) |
There was a problem hiding this comment.
Status 201 means that we've newly created an object at a URI that the response provides. I believe 204 is correct here.
| context={"authenticator": authenticator}, | ||
| send_email=True, | ||
| ) | ||
| return Response(serialize(interface)) |
There was a problem hiding this comment.
The "if" and "else" bodies are independent modes of the endpoint. Let's extract both to their own helper methods.
There was a problem hiding this comment.
Sounds good, ill move it into their own helper methods, but I would still need to keep the if and else right? I don't want to regenerate the recovery code if i want to rename it
… changed response codes
leedongwei
reviewed
Oct 26, 2021
static/app/views/settings/account/accountSecurity/components/u2fEnrolledDetails.tsx
Outdated
Show resolved
Hide resolved
static/app/views/settings/account/accountSecurity/components/u2fEnrolledDetails.tsx
Outdated
Show resolved
Hide resolved
static/app/views/settings/account/accountSecurity/components/u2fEnrolledDetails.tsx
Outdated
Show resolved
Hide resolved
static/app/views/settings/account/accountSecurity/components/u2fEnrolledDetails.tsx
Show resolved
Hide resolved
static/app/views/settings/account/accountSecurity/components/u2fEnrolledDetails.tsx
Outdated
Show resolved
Hide resolved
static/app/views/settings/account/accountSecurity/components/u2fEnrolledDetails.tsx
Outdated
Show resolved
Hide resolved
static/app/views/settings/account/accountSecurity/accountSecurityDetails.tsx
Show resolved
Hide resolved
static/app/views/settings/account/accountSecurity/components/u2fEnrolledDetails.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow user to rename their u2f device after being registered.
As stated in user_authenticator_details, put has been updated to rename a device's name. This put endpoint is temporary for now as we look for a new home for the parts about regenerating recover codes
https://getsentry.atlassian.net/browse/ER-641