feat(symbolication): Selection logic for low priority queue [NATIVE-211] #29258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loewenheim
reviewed
Oct 12, 2021
relaxolotl
reviewed
Oct 12, 2021
otherwise mypy isn't very happy. Though I would be because I'd get a nice sentry error when it would be broken. Now I'll still get that but mypy wasn't smart enough to spot that...
loewenheim
reviewed
Oct 13, 2021
relaxolotl
reviewed
Oct 14, 2021
Co-authored-by: Sebastian Zivota <loewenheim@users.noreply.github.com>
flub
commented
Oct 18, 2021
|
|
||
| @dataclasses.dataclass(frozen=True) | ||
| class DurationHistogram: | ||
| def rate(self, period: Union[int, _Period] = TOTAL_PERIOD) -> float: |
There was a problem hiding this comment.
@loewenheim since you asked about tagged unions in python. I think generally you don't but duck-type instead. It seems with mypy this looks something like this. It was a little easier before mypy, the class attribute would have been simply TOTAL_PERIOD = object() and you get a singleton you can compare with is. Apparently with mypy you need to do this kind of enum-with-one-variant thing.
There was a problem hiding this comment.
The Rust-like tagged union would have been an arg of type:
enum Period {
Total,
Partial(u32),
}
in case you're lost why i bring this up here.
They're kind of covered already, since we already asserted a spike does not break through a low rate. But I guess it doesn't do any harm.
added 2 commits
October 18, 2021 18:08
|
PTAL |
relaxolotl
reviewed
Oct 18, 2021
relaxolotl
approved these changes
Oct 18, 2021
Thanks for the thorough review! |
Swatinem
approved these changes
Oct 19, 2021
Also, I completely forgot to commit this new test file before. Oops.
Without these the tests are not in a package and file names result in conflicting test names.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of refactoring still, but I think this is more or less my first proposal at the logic.