feat(cmp_alerts): Return current and comparison count from stats api, instead of percent #29245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of percent This changes the response from `OrganizationEventsStatsEndpoint` to include the current count and comparisonCount values when `comparisonDelta` is passed, rather than returning the % change. To calculate the delta change value on the frontend use `((count / comparisonCount) - 1) * 100`, making sure to not divide by 0.
evanpurkhiser
approved these changes
Oct 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the response from
OrganizationEventsStatsEndpointto include the current count andcomparisonCount values when
comparisonDeltais passed, rather than returning the % change. Tocalculate the delta change value on the frontend use
((count / comparisonCount) - 1) * 100, makingsure to not divide by 0.