Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(js): Use localeCompare for sort in projectsStore#getAll #29244

Merged
merged 1 commit into from
Oct 12, 2021
Merged

ref(js): Use localeCompare for sort in projectsStore#getAll #29244

merged 1 commit into from
Oct 12, 2021

Conversation

evanpurkhiser
Copy link
Member

No description provided.

@evanpurkhiser evanpurkhiser requested a review from a team October 12, 2021 00:03
davidenwang
davidenwang approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@davidenwang davidenwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh shoot nice cleanup

@github-actions
Copy link
Contributor

size-limit report

Path Base Size (f6c0e4b) Current Size Change
src/sentry/static/sentry/dist/entrypoints/app.js 52.69 KB 52.69 KB +0.01% 🔺
src/sentry/static/sentry/dist/entrypoints/sentry.css 70.9 KB 70.9 KB 0%

@evanpurkhiser
Copy link
Member Author

need to be sure this sorts the same

@evanpurkhiser evanpurkhiser merged commit 9891a95 into master Oct 12, 2021
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/ref-js-use-localecompare-for-sort-in-projectsstore-getall branch October 12, 2021 00:48
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@scttcper scttcper scttcper approved these changes

@davidenwang davidenwang davidenwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evanpurkhiser @scttcper @davidenwang