Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workflow): Add team label to team insights dropdown #29243

Merged
merged 2 commits into from
Oct 12, 2021

Conversation

scttcper
Copy link
Member

  • Adds a label to the team picker dropdown and makes the two dropdowns match visually
  • unset some box shadows in the panel tables that shows up when there is only 1 or 2 items.

image

- Adds a label to the team picker dropdown and makes the two dropdowns match visually
- unset some box shadows in the panel tables that shows up when there is only 1 or 2 items.
@scttcper scttcper requested a review from a team October 11, 2021 23:48
@@ -59,6 +60,7 @@ function TeamInsightsOverview({
location,
router,
}: Props) {
const theme = useTheme();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Member

@matejminar matejminar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks kind of weird:

Kapture.2021-10-12.at.09.51.45.mp4

@scttcper
Copy link
Member Author

@matejminar pushed it over

image

@davidenwang had to rearrange the style overrides, but it doesn't appear to be used at the moment

@github-actions
Copy link
Contributor

size-limit report

Path Base Size (a720dc4) Current Size Change
src/sentry/static/sentry/dist/entrypoints/app.js 52.84 KB 52.83 KB -0.01% 🔽
src/sentry/static/sentry/dist/entrypoints/sentry.css 70.9 KB 70.9 KB 0%

@scttcper scttcper enabled auto-merge (squash) October 12, 2021 18:44
@scttcper scttcper merged commit 692844d into master Oct 12, 2021
@scttcper scttcper deleted the scttcper/insights-style-adjustments branch October 12, 2021 18:53
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants