-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jobs): Come struggle at react code with us #29241
Merged
evanpurkhiser
merged 1 commit into
master
from
evanpurkhiser/feat-jobs-come-struggle-at-react-code-with-us
Oct 12, 2021
Merged
feat(jobs): Come struggle at react code with us #29241
evanpurkhiser
merged 1 commit into
master
from
evanpurkhiser/feat-jobs-come-struggle-at-react-code-with-us
Oct 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
0a3a558
to
d1f0e0b
Compare
scefali
reviewed
Oct 11, 2021
@@ -64,6 +64,11 @@ | |||
// <OrganizationDetails> <-- Most routes live within the | |||
// OrganizationDetails, which handles loading | |||
// details for the org, projects, and teams. | |||
// | |||
// | |||
// Did you read through this whole thing and don't even work here? [1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
// Did you read through this whole thing and don't even work here? [1] | |
// Did you read through this whole thing even though you don't work here (yet)? [1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
// Did you read through this whole thing and don't even work here? [1] | |
// Did you read through this even though you don't even work here (yet)? [1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs more emojis.
scefali
approved these changes
Oct 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👀