ref(js): Convert a number of withApi's -> useApi's #29239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
davidenwang
reviewed
Oct 11, 2021
| const {api, location, selection, organization, projects} = props; | ||
| const {location, selection, organization, projects} = props; | ||
|
|
||
| const api = useApi(); |
There was a problem hiding this comment.
do we have a preference for having this line above the destructuring of props or below it?
There was a problem hiding this comment.
Yeah I noticed this one. Probably above, though it doesn't really matter, as long as it's not before an early return, which would be a problem
b9691f5 to
c399cd8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.