Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metric-alerts): Create/update Alert Rule UI Components #29236

Merged
merged 7 commits into from
Oct 12, 2021

Conversation

NisanthanNanthakumar
Copy link
Contributor

@NisanthanNanthakumar NisanthanNanthakumar commented Oct 11, 2021

Objective:

Metric Alert POST/ or PUT/ request body should accept the settings from the sentry app alert rules. It forwards the data to the Sentry App using the AlertRuleAction Creator and saves the data in Sentry.

We also bubble up the error response text from the Sentry App to the UI. This happens for both Metric and Issue Alerts.

Test Plan:

Added tests for the AlertRuleTriggerAction serializer

@NisanthanNanthakumar NisanthanNanthakumar requested review from a team October 11, 2021 20:55
Copy link
Member

@leeandher leeandher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think there's a few tests that need updating now that the uri field isn't coming from the frontend anymore. If you'd like, you can delete this line and it'd stop the frontend sending it as well (for issue alerts), but if not and I can do it on my next PR.

https://github.com/getsentry/sentry/blob/master/static/app/views/organizationIntegrations/sentryAppExternalForm.tsx#L328

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2021

size-limit report

Path Base Size (a15d813) Current Size Change
src/sentry/static/sentry/dist/entrypoints/app.js 52.83 KB 52.83 KB +0.01% 🔺
src/sentry/static/sentry/dist/entrypoints/sentry.css 70.9 KB 70.9 KB 0%

@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants