feat(alert-rules): Add validation for schema fields attached to alert rules #29226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
429567b to
d98df94
Compare
mgaeta
reviewed
Oct 11, 2021
ceorourke
reviewed
Oct 11, 2021
ceorourke
reviewed
Oct 11, 2021
mgaeta
reviewed
Oct 11, 2021
mgaeta
reviewed
Oct 12, 2021
mgaeta
approved these changes
Oct 12, 2021
68d4128 to
83a709f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See API-2168
This PR adds some validation to the forms coming in to create alert rules with UI components. Since the payload is directly sent to the third party, and we have a schema of what to expect, this will eliminate some obviously malformed request instead of ignoring errors or forcing a network request to identify them.
TODO
Full API Demo
Here you can see all the errors that are being tested for being surfaced. These errors would show up as toasts above the alert rule's action nodes, but it would involve bypassing the frontend validation which is a lot of tedious work to image all the errors showing up, so instead I just recorded some Postman proof. Here's an example of the error being surfaced.
And here are all the possible errors that can be surfaced:
Dynamic.Form.Validation.API.mov