feat(discover): Previous period on charts #29211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for previous period on unfurls.
size-limit report
|
shruthilayaj
commented
Oct 8, 2021
Comment on lines
+200
to
+210
|
|
||
| const RGB_LIGHTEN_VALUE = 30; | ||
| export const lightenHexToRgb = (colors: string[]) => | ||
| colors.map(hex => { | ||
| const rgb = [ | ||
| Math.min(parseInt(hex.slice(1, 3), 16) + RGB_LIGHTEN_VALUE, 255), | ||
| Math.min(parseInt(hex.slice(3, 5), 16) + RGB_LIGHTEN_VALUE, 255), | ||
| Math.min(parseInt(hex.slice(5, 7), 16) + RGB_LIGHTEN_VALUE, 255), | ||
| ]; | ||
| return `rgb(${rgb[0]}, ${rgb[1]}, ${rgb[2]})`; | ||
| }); |
There was a problem hiding this comment.
Reusing what @edwardgou-sentry has here
|
Looks good to me! just one question about the line series stacking |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for previous period on unfurls.
Screenshots
Chart debug:
