ref(releasehealth): Implement get_num_sessions_per_project on metrics backend [INGEST-249] #29208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
approved these changes
Oct 11, 2021
| Returns the number of sessions for each project specified. | ||
| Additionally | ||
| """ | ||
| return _get_num_sessions_per_project( # type: ignore |
There was a problem hiding this comment.
nit: Do we actually need #type: ignore here? _get_num_sessions_per_project looks fully typed.
There was a problem hiding this comment.
Yes we do, it puzzled me as well,
I think that it is because sentry/snuba/sessions.py is not included in the mypy checked files and it assumes that it returns Any since it can't check it.
Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like in #28598, port get_num_sessions_per_project from sentry.snuba.sessions to metrics.
INGEST-249