Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(ui): Refactor sessions existence checks #29205

Merged
merged 1 commit into from
Oct 12, 2021
Merged

ref(ui): Refactor sessions existence checks #29205

merged 1 commit into from
Oct 12, 2021

Conversation

matejminar
Copy link
Member

project now has a top-level property hasSessions, we do not need to fetch sessions on frontend to get this info anymore.

@matejminar matejminar requested review from a team October 8, 2021 11:18
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2021

size-limit report

Path Base Size (c8b1146) Current Size Change
src/sentry/static/sentry/dist/entrypoints/app.js 52.68 KB 52.68 KB -0.01% 🔽
src/sentry/static/sentry/dist/entrypoints/sentry.css 70.9 KB 70.9 KB 0%

@matejminar matejminar removed the request for review from a team October 11, 2021 17:24
@matejminar matejminar merged commit 983b740 into master Oct 12, 2021
@matejminar matejminar deleted the ref/session-existence-checks branch October 12, 2021 08:04
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@taylangocmen taylangocmen taylangocmen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matejminar @taylangocmen