Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workflow): Collapse team misery on more than 8 results #29199

Merged
merged 6 commits into from
Oct 11, 2021

Conversation

scttcper
Copy link
Member

@scttcper scttcper commented Oct 8, 2021

sorts by change and collapses the results with no change

Screen Shot 2021-10-07 at 5 07 18 PM

@scttcper scttcper requested a review from a team October 8, 2021 00:09
Copy link
Member

@matejminar matejminar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think app/components/collapsible.tsx could be used to handle some of the logic?

@scttcper
Copy link
Member Author

scttcper commented Oct 8, 2021

Do you think app/components/collapsible.tsx could be used to handle some of the logic?

Good question, after looking at it a bit the logic would work but i need the "show more" button to be outside of PanelTable otherwise i have to override a ton of table styles

location={routerContext.context}
/>,
{context: routerContext}
);

await waitFor(() => {
expect(wrapper.queryByTestId('loading-indicator')).not.toBeInTheDocument();
expect(screen.queryByTestId('loading-indicator')).not.toBeInTheDocument();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@scttcper scttcper changed the title feat(workflow): Collapse team misery with no change feat(workflow): Collapse team misery on more than 8 results Oct 11, 2021
@scttcper scttcper merged commit 2642bd8 into master Oct 11, 2021
@scttcper scttcper deleted the scttcper/collapse-misery branch October 11, 2021 17:29
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants