fix(ui) Fix issue stats chart colours in dark mode #29162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the indicator borders in dark mode.
| @@ -2,10 +2,11 @@ | |||
| import './components/markPoint'; | |||
|
|
|||
| import * as React from 'react'; | |||
| import {withTheme} from '@emotion/react'; | |||
There was a problem hiding this comment.
should we use useTheme ? :)
There was a problem hiding this comment.
Yeah, I did this before Evan's useTheme changes. I'll get this updated.
There was a problem hiding this comment.
Fixed now and moved to a function component.
scttcper
approved these changes
Oct 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the indicator borders in dark mode.
Before
After