fix(discover): Check yAxis list contains equation functions when adding widget from discover #29153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-widget-check-y-axis-equation
…-widget-check-y-axis-equation
…-widget-check-y-axis-equation
Zylphrex
reviewed
Oct 12, 2021
| @@ -430,11 +442,67 @@ describe('EventsV2 > SaveQueryButtonGroup', function () { | |||
| wrapper.find('DiscoverQueryMenu').find('Button').first().simulate('click'); | |||
| wrapper.find('MenuItem').first().simulate('click'); | |||
| await tick(); | |||
| await wrapper.update(); | |||
| await tick(); | |||
There was a problem hiding this comment.
Why is tick called twice here?
There was a problem hiding this comment.
Found that subsequent tests will have leaky data without the second tick(). This looks like something to do with enzyme component handling. Removed wrapper.update() since it wasn't actually doing anything here.
| return ( | ||
| !parsed.error && | ||
| parsed.tc.functions.every( | ||
| ({term}) => typeof term === 'string' && yAxis.includes(term) |
There was a problem hiding this comment.
Does this need to check if the equation is on aggregates? Because we can add equations on non aggregatesike transaction.duration.
There was a problem hiding this comment.
Aggregates are filtered out ahead of time, so shouldn't be necessary to check again. 👍
Zylphrex
approved these changes
Oct 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #29087 users will be able to add equations to all widget visualization types.
When adding a widget from discover, we need to make sure that any equations passed into the Y-Axis must have their comprising functions included as Y-Axis values as well (otherwise the equation will not work). This change will enforce this check when pulling Y-Axis values from discover to the Add to Dashboard widget modal.