Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(ui): Remove legacy release details codepaths #29150

Merged
merged 9 commits into from
Oct 13, 2021
Merged

ref(ui): Remove legacy release details codepaths #29150

merged 9 commits into from
Oct 13, 2021

Conversation

matejminar
Copy link
Member

@matejminar matejminar commented Oct 7, 2021 •
edited
Loading

The release-comparison feature flag is fully adopted, we can remove all legacy experience code.

Will remove the backend flag in the follow-up PR.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2021 •
edited
Loading

size-limit report

Path Base Size (983b740) Current Size Change
src/sentry/static/sentry/dist/entrypoints/app.js 52.83 KB 52.93 KB +0.19% 🔺
src/sentry/static/sentry/dist/entrypoints/sentry.css 70.9 KB 70.9 KB 0%

@matejminar matejminar marked this pull request as ready for review October 8, 2021 09:25
@matejminar matejminar requested review from a team October 8, 2021 09:25
@matejminar matejminar requested a review from a team as a code owner October 8, 2021 09:25
@matejminar matejminar requested review from a team and removed request for a team October 8, 2021 09:25
markstory
markstory approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test results look good, and I clicked around in releases in our org and everything seemed fine.

@matejminar matejminar merged commit e0ab3fa into master Oct 13, 2021
@matejminar matejminar deleted the ref/remove-legacy-release-detail branch October 13, 2021 09:32
@matejminar matejminar mentioned this pull request Oct 19, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@markstory markstory markstory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matejminar @markstory