fix(dev): Install Python 3.6.x with --patch on Big Sur #29149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes regression introduced in #29058. On Big Sur, we cannot install Python 3.6.x without patching the source code first.
joshuarli
reviewed
Oct 7, 2021
| # I'm assuming that SENTRY_PYTHON_VERSION won't be used to specify a 3.6 version to simplify the condition | ||
| # When a user sets a SENTRY_PYTHON_VERSION they intend to use a non-default version that I assume | ||
| # is newer, thus, can install with the non-source-patched default pyenv install command | ||
| if query-big-sur && [[ -z "${SENTRY_PYTHON_VERSION:-}" ]]; then |
There was a problem hiding this comment.
This won't work; I have SENTRY_PYTHON_VERSION set to 3.8.12 and the patch only applies to 3.6.10.
I think the issue you're having is that you're on M1 and big sur.
There was a problem hiding this comment.
So we should just patch install if [ "${PYENV_VERSION}" = 3.6.10 ] and remove the platform and os checks.
There was a problem hiding this comment.
I've tested it on my Intel machine and it seems to work in both cases:
I've also managed to use the bootstrap script to generate both Python environments.
There was a problem hiding this comment.
I was wrong - what you have, works.
joshuarli
approved these changes
Oct 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regression introduced in #29058.
On Big Sur, we cannot install Python 3.6.x without patching the source code first.